Dzhus/project fix #137
Merged
Dzhus/project fix #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o parent if user enters invalid data"
VyacheslavDzhus
requested review from
dmitrykiev,
SergeyNovitsky,
DmyMi,
P0linux,
OlhaHoliak,
YehorOstapchuk and
v-ivanchuk
v-ivanchuk
reviewed
Jun 1, 2021
| @@ -18,7 +18,7 @@ public class Workshop | |||
| [DataType(DataType.PhoneNumber)] | |||
| [Required(ErrorMessage = "Phone number is required")] | |||
| [RegularExpression( | |||
| @"([\d]{9})", | |||
| @"([\d]{10})", | |||
| ErrorMessage = "Phone number format is incorrect. Example: 380 50-123-45-67")] | |||
There was a problem hiding this comment.
According to regular expression, example number should be like "0501234567"
v-ivanchuk
reviewed
Jun 1, 2021
| @@ -37,11 +37,11 @@ public class Workshop | |||
| public string Instagram { get; set; } = string.Empty; | |||
|
|
|||
| [Required(ErrorMessage = "Children's min age is required")] | |||
| [Range(0, 16, ErrorMessage = "Min age should be a number from 0 to 16")] | |||
| [Range(0, 18, ErrorMessage = "Min age should be a number from 0 to 16")] | |||
There was a problem hiding this comment.
Min age should be a number from 0 to 18. And for DTO the same
v-ivanchuk
reviewed
Jun 1, 2021
| public int MinAge { get; set; } | ||
|
|
||
| [Required(ErrorMessage = "Children's max age is required")] | ||
| [Range(0, 16, ErrorMessage = "Max age should be a number from 0 to 16")] | ||
| [Range(0, 18, ErrorMessage = "Max age should be a number from 0 to 16")] |
There was a problem hiding this comment.
Max age should be a number from 0 to 18. And for DTO the same
v-ivanchuk
approved these changes
Jun 1, 2021
|
SonarCloud Quality Gate failed. |
DmyMi
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.